Skip to content

Conversation

@Akanksha13-dev
Copy link

@Akanksha13-dev Akanksha13-dev commented Oct 24, 2025

Description

Screen.Recording.2025-11-03.at.11.39.10.AM.mov

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@Akanksha13-dev Akanksha13-dev force-pushed the GH-9-a-1 branch 2 times, most recently from 1c49bec to cd41b4a Compare October 24, 2025 11:21
@Akanksha13-dev Akanksha13-dev marked this pull request as ready for review October 27, 2025 03:54
: input.suffix) || ''
}}
<ng-container *ngIf="input.nextLine; else defaultInput">
<div class="input-next-line">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are adding if and else block only for adding input-next-line class, then can't we use something like

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not just adding class, we are adding div with class here. to render inputs in multiline and second one all inputs in same line

Copy link
Collaborator

@samarpan-b samarpan-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to be discussed and reviewed with @akshatdubeysf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants